Allow inputs to have configurable base class (#371)#392
Open
luci-bytes wants to merge 1 commit intomirumee:mainfrom
Open
Allow inputs to have configurable base class (#371)#392luci-bytes wants to merge 1 commit intomirumee:mainfrom
luci-bytes wants to merge 1 commit intomirumee:mainfrom
Conversation
luci-bytes
force-pushed
the
Issue#371
branch
from
92a498e to
3411dda
Compare
DamianCzajkowski
force-pushed
the
main
branch
from
e74ba77 to
e8458ec
Compare
luci-bytes
force-pushed
the
Issue#371
branch
from
3411dda to
c7525e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #371
The configuration in the pyproject.toml now takes the additional setting ignore_extra_fields. ignore_extra_fields is true by default as BaseModel ignores extra fields by default. If it is set to false, extra='forbid' will be appended to the BaseModel in the client. If additional fields are then provided, an error is thrown.
Additionally three unit tests have been added, which test: